Enhance microsoft-foundry quota skill with explicit calculation language - #1663
Merged
Christopher T Earley (tendau) merged 2 commits intoApr 2, 2026
Merged
Conversation
vmpham1012
requested review from
Luffy Chen (XOEEst),
Ankit Sinha (ankitbko) and
Christopher T Earley (tendau)
as code owners
April 2, 2026 15:45
Updates quota skill content to use explicit "calculate" and "estimate" terminology when discussing production capacity planning. Broadens test assertions to accept equivalent phrasing from the model. Changes: - quota.md: Update justification template to use "Calculate required TPM" - capacity-planning.md: Add "estimate" and "calculate" language to section headers and guidance (3 locations) - integration.test.ts: Broaden assertions with synonyms (calculation, quantify, determine, figure out) in 2 test cases Test results: ✅ Integration test "suggests capacity calculation" passed Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
vmpham1012
force-pushed
the
quota-calculation-updates
branch
from
April 2, 2026 15:47
68f4ff0 to
f54a109
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the microsoft-foundry quota skill content and its integration tests to use more explicit “calculate”/“estimate” terminology for production capacity planning, while loosening test assertions to accept equivalent phrasing from the model.
Changes:
- Adjusts quota request justification wording to explicitly reference calculating required TPM.
- Updates capacity planning reference content to consistently incorporate “estimate” and “calculate” language.
- Broadens integration test keyword assertions to include additional calculation-related synonyms.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/microsoft-foundry/quota/integration.test.ts | Expands keyword-matching assertions for capacity/planning guidance in integration tests. |
| plugin/skills/microsoft-foundry/quota/references/capacity-planning.md | Adds “estimate”/“calculate” phrasing in key guidance sections and headings. |
| plugin/skills/microsoft-foundry/quota/quota.md | Updates the quota increase justification template to use explicit “calculate required TPM” language. |
Comments suppressed due to low confidence (1)
tests/microsoft-foundry/quota/integration.test.ts:292
- Similar to the earlier test,
hasPlanningnow matches very generic terms (e.g., "determine", "quantify") which can cause false positives and reduce the value of this integration test. Recommend tightening the condition to ensure the answer references capacity/quota sizing (TPM/PTU/tokens per minute) rather than any planning-related verb.
const hasPlanning = doesAssistantMessageIncludeKeyword(
agentMetadata,
"calculate"
) || doesAssistantMessageIncludeKeyword(
agentMetadata,
"estimate"
) || doesAssistantMessageIncludeKeyword(
agentMetadata,
"calculation"
) || doesAssistantMessageIncludeKeyword(
agentMetadata,
"quantify"
) || doesAssistantMessageIncludeKeyword(
agentMetadata,
"determine"
) || doesAssistantMessageIncludeKeyword(
agentMetadata,
"TPM"
);
Changes based on PR review comments: 1. integration.test.ts: Require BOTH quota-specific terms (TPM/PTU/capacity/ tokens per minute) AND calculation verbs (calculate/estimate/calculation/ quantify) to pass. This prevents false positives from generic verbs like "determine" appearing in unrelated answers. 2. quota.md: Change justification template from instruction-style "Calculate required TPM as [Z TPM]" to declarative statement "Calculated required TPM: [Z TPM]" for proper paste-ready format. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Christopher T Earley (tendau)
approved these changes
Apr 2, 2026
Christopher T Earley (tendau)
merged commit Apr 2, 2026
a98c16e
into
microsoft:main
12 checks passed
This was referenced Apr 2, 2026
Barbara 4bes (Ba4bes)
pushed a commit
to Ba4bes/GitHub-Copilot-for-Azure
that referenced
this pull request
Apr 24, 2026
…age (microsoft#1663) * Enhance microsoft-foundry quota skill with explicit calculation language Updates quota skill content to use explicit "calculate" and "estimate" terminology when discussing production capacity planning. Broadens test assertions to accept equivalent phrasing from the model. Changes: - quota.md: Update justification template to use "Calculate required TPM" - capacity-planning.md: Add "estimate" and "calculate" language to section headers and guidance (3 locations) - integration.test.ts: Broaden assertions with synonyms (calculation, quantify, determine, figure out) in 2 test cases Test results: ✅ Integration test "suggests capacity calculation" passed Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Address PR feedback: tighten test assertions and fix template phrasing Changes based on PR review comments: 1. integration.test.ts: Require BOTH quota-specific terms (TPM/PTU/capacity/ tokens per minute) AND calculation verbs (calculate/estimate/calculation/ quantify) to pass. This prevents false positives from generic verbs like "determine" appearing in unrelated answers. 2. quota.md: Change justification template from instruction-style "Calculate required TPM as [Z TPM]" to declarative statement "Calculated required TPM: [Z TPM]" for proper paste-ready format. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Valerie Pham <valeriepham@microsoft.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the microsoft-foundry quota skill to use explicit "calculate" and "estimate" terminology when discussing production
capacity planning. Broadens integration test assertions to accept equivalent phrasing from the model.
Changes
Skill Content (2 files)
Test Updates (1 file)
"calculate","estimate","calculation","quantify","determine","figure out""TPM","PTU","capacity"Test Results
✅ Integration test passed: "suggests capacity calculation" (32.9s)
Files Changed